Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): strip all BOMs #19230

Closed
wants to merge 1 commit into from
Closed

fix(utils): strip all BOMs #19230

wants to merge 1 commit into from

Conversation

btea
Copy link
Collaborator

@btea btea commented Jan 20, 2025

Description

Reference rollup/rollup#5806, the file content may start with multiple BOMs.

sapphi-red
sapphi-red reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should strip multiple BOMs because that changes the meaning of the content. If the file has multiple BOMs, it should be a parse error.

@bluwy
Copy link
Member

bluwy commented Jan 20, 2025

Agree too, though I'm not sure if we have to add more code for a parse error if there's multiple BOMs. It feels like a very rare case to happen.

@btea
Copy link
Collaborator Author

btea commented Jan 20, 2025

OK, let's keep it as it is.

@btea btea closed this Jan 20, 2025
@btea btea deleted the fix/strip-all-boms branch January 20, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btea @bluwy @sapphi-red